IMO, it depends.
If your car has a regular tape deck, I'd prefer a tape adapter. The quality is better, and the countless search for an undistorted FM channel is over.
If you change cars a lot (like using rental cars), the iTrip is probably the better option.
I myself use both, but the iTrip only when there is no tape or line-in available.
-t