[type_r503]

Hello,

I seem to be having some trouble with a document based app. I have multiple windowcontrollers being created from the documents makeDocumentControllers method. Each window type is loaded from different NIB files. The problem comes if the user closes one of the windows and its windowController. If I click on the menu or make a selection from the dockmenu or try to create another documentcontroller the app crashes with Sigbus.

Some help or a point in the right direction would be much appriciated.

type r

[type_r503]

anyone?

[Chuckit]

Well, it sounds like one of the window controllers is being released when it shouldn't be. I don't know what more I can say since I have no idea what your code looks like, and thus no idea what mistakes it contains. If you feel like posting a small example that duplicates the problem, it would be a lot more helpful in pinpointing it.

[type_r503]

Thanks, here is the code

Code:
-(void) makeWindowControllers
{
   tableController = [[TableDataController alloc]    initWithWindowNibName:@"TableData" ];
        
                    
                    
            if(![windowControllers containsObject: tableController])   
            {     
                                       [tableController setDocument: self];
                
                    [tableController windowWillLoad];
                    
                    
                   
                                
                    [windowControllers addObject: tableController];
                    
                }


}


-(void) removeWindowController:(NSWindowController*) windowController
{
    
    
    if([windowControllers containsObject: windowController])
    {
        [windowController autorelease];
        
        
        
    }
    
}

Thank you for your help

type R

[Chuckit]

I think your problem is caused by the -removeWindowController: method. It looks like you're releasing an object in an array without removing it from the array. Then, when you try to access the objects in the array, that one has been deallocated and your program blows up.

You really don't need to implement that method, or have the windowControllers array. Just implement your -makeWindowControllers like so:

Code:
- (void)makeWindowControllers
{
     tableController = [[TableDataController alloc] initWithWindowNibName:@"TableData"];
//Adds the controller to your document's array and makes this its document.
     [self addWindowController:tableController];
//Since the array retains the controller for your document, no need to keep a hold of it.
     [tableController release];
}

And if you need to access the array of window controllers, just use NSDocument's -windowControllers method.

[asd]

There are a few changes you should make:
First of all in the -makeWindowControllers method you need to call [self addWindowContoller:tableController] to add the newly created window controller to the documents list of window controllers. That method automstically sets the tabelController's document correctly so can eliminate that part of the code.

i.e. your code should just be:

-(void) makeWindowControllers
{
tableController = [[TableDataController alloc]initWithWindowNibName:@"TableData" ];

[self addWindowController:tableController];

}

Secondly, i agree that you don't need to overide -removeWindowController method (AFAIK).

Hope that helps

[type_r503]

i am an idiot. Simple overthinking.

Thanks