Welcome to the MacNN Forums.

ctlq · Dec 6, 2004, 06:44 PM

http://forums.devshed.com/t35298/s.html

I'm trying to do the same thing this guy is asking for but the solution someone provided doesn't work. Does anyone know how to fix it?

Chris O'Brien · Dec 7, 2004, 04:12 AM

The code provided looks like it should work...

What errors is it throwing and how are you putting it in your page?

ctlq · Dec 7, 2004, 09:00 AM

<html>
<head>

<script type="text/Javascript">

</script>
</head>
<body onLoad="loadClick()">
<a href="http://www.macnn.com">macnn</a>
</body>
</html>

Chris O'Brien · Dec 7, 2004, 10:05 AM

Ah right, I see.
Basically, if you put an alert(target.nodeName) before the if statement on the nodeName, you'll see what each browser is reporting.
Firefox is reporting that it's BODY - which means you should forget the .parentNode bit. However, to complicate matters, Safari is reporting everything as a #TEXT node. This may be because I'm using Safari 2, you should check for 1.2.

Anyhoo - rather than adding the event listener to the whole body, you could just add it to the anchors... Something like:

Code:
<html>
<head>

<script type="text/Javascript">
<!--
function AClick(e) {
    var target;
    if (document.addEventListener) {
        target = e.target;
        if (target.nodeName.toLowerCase() != "a") target = target.parentNode;
    } else {
        target = event.srcElement;
    }
    window.location.href = 'myprog.php?target=' + target.href;
}

function loadClick() {
    var a = document.getElementsByTagName("BODY")[0].getElementsByTagName("A");
    for (var i=0; i < a.length; i++) {
        if (document.addEventListener) {
            a[i].addEventListener("click", AClick, true);
        } else {
            a[i].attachEvent("onclick", AClick); 
        }
    }
}
// -->
</script>
</head>
<body onLoad="loadClick()">
<a href="http://www.macnn.com">macnn</a>
<a href="http://www.macnn.com">macnn</a>
<div><a href="http://www.macnn.com">macnn</a></div>
<div>
<span><a href="http://www.macnn.com">macnn</a></span>
<a href="http://www.macnn.com">macnn</a>
</div>
</body>
</html>

Note that IE 5 Mac doesn't support attachEvent, so it won't work in that. It should work in IE Win though. I added in a bunch of links nested inside other elements to show that it will pick up every link on the oage.

ctlq · Dec 7, 2004, 10:34 AM

I tried your code and couldn't get it to work in any browsers. How'd you get it to work?

Chris O'Brien · Dec 7, 2004, 10:45 AM

Just save what I pasted as a .html document and open it in a browser... You must have a file called myprog.php in the same directory to actually see it working, obviously.

What browsers are you trying it in? I tried it in IE6, Firefox 1 and Safari 2 just now.

ctlq · Dec 7, 2004, 10:54 AM

I've tried in firefox 1, ie6 win, safari 1.3 DP5, camino.
Try this link:
http://msu.edu/~youngad6/macnn.html

Chris O'Brien · Dec 7, 2004, 11:20 AM

Ah, use this instead, it's much easier:

Code:
function loadClick() {
    var a = document.getElementsByTagName("BODY")[0].getElementsByTagName("A");
    for (var i=0; i < a.length; i++) {
        a[i].setAttribute("href", "myprog.php?target=" + a[i].getAttribute("href"));
    }
}

ctlq · Dec 7, 2004, 11:22 AM

It works! Thanks a ton!!!

ctlq · 11:55 AM

Actually, one more thing. (I know I'm pushing my luck

) Now the links show up in the statusbar as:
http://somewhere.com/myprog.php?targ.../www.macnn.com

Is there a way to make the link only show up as the target= part in the statusbar when the mouse goes over it?