[Apocalypse]

Something is going wrong with how I am creating some array. First of all I am trying to use the application:openFile: method to read incoming files into an NSArray. I then try and pass this array as an argument list to an NSTask. However, whenever I try to pass this array to the NSTask I get an "EXC_BAD_ACCESS" error. I tried to check the integrity of the NSArray by outputting the contents to a textview with a for loop but when I try and extract the "count" property it gives me the same error and crashes.

Here is some of the code:
- (BOOL)applicationNSApplication *)theApplication openFileNSString *)filename
{

if (!listing){
listing = (NSArray *)[NSArray arrayWithObject:filename];
}
else{
[self addToArray:filename];
}
return YES;
}

- (void)addToArrayNSString *)filename
{
listing = (NSArray *)[listing arrayByAddingObject:filename];
}

...and trying to extract data later:
for (county=1; county <[listing count]; county++)
{
[contents setString:[[contents string] stringByAppendingString:[listing objectAtIndex:county]]];
}


This has me completely stumped so can someone help me out?

Thanks,
Jeff.

[lindberg]

Since listing is an instance variable, you need to "own" a reference to it. [NSArray arrayWithObject:obj] returns an autoreleased array, so by the time the next user event happens, it has been freed. The errors you're seeing happen when you try to send messages to a freed object.

Either add a -retain call ([[NSArray arrayWithObject:obj] retain]), or use the alloc/init version, which has an implicit retain ([[NSArray alloc] initWithObject:obj]).

You'll probably also find it easier to use an NSMutableArray. If contents is an NSMutableString, you can just append the string to it as well...

- (BOOL)applicationNSApplication *)theApplication openFileNSString *)filename
{
[self addToArray:filename];
}

- (void)addToArrayNSString *)filename
{
if (listing == nil)
listing = [[NSMutableArray alloc] initWithObject:filename];
else[listing addObject:filename];
}

...and trying to extract data later:
for (county=1; county <[listing count]; county++)
{
// Assuming contents is an NSMutableString here
// also, you're starting at index 1, this will skip the
// first entry in the listing array here (which is index 0).
[contents appendString:[listing objectAtIndex:county]]];
}

[Angus_D]

You're using a convenience constructor, which returns and -autorelease'd object. You need to retain it. Also, you're not freeing memory correctly later on. OK, looks like lindberg replied to this between me loading the page and hitting the reply button