I usually make my icons in Photoshop or Illustrator in combination with the iconbuiler plug-in from the iconfactory, sometimes I use Iconographer for the 16*16 and 32*32 resources. For quick and dirty jobs ( application folder, DMG icons, ... ) you can use CanCombineIcons....
Be sure to read the tutorials included with the iconbuilder plug-in...